MediaWiki talk:Gadget-GalleryDetails.js

Archives

Archive 1 Archive 2 Archive 3

Conversations older than 7 days will be archived automatically.

Not working in some cats

{{Editprotected}}

At least at Category:Low quality runic letters there seems to be a stumbling block of some sort for this gadget, while it’s working for many other cats I tried it today with. -- Tuválkin ✉ ✇ 01:03, 15 June 2023 (UTC)

Doesn't work for me either. A few days ago there was no such problem. ‎—^מקףHyphen_෴ 21:17, 10 July 2023 (UTC)

Seems to be caused by phab:T314318, specifically by mw:Parsoid/Parser Unification/Media structure/FAQ#The "image" class is no longer present on file description links breaking line 760 (there may be other breakages as well). @Arlolra: You asked to be pinged about T314318-related breakages. —Tacsipacsi (talk) 00:47, 19 July 2023 (UTC)

Actually, this only explains why the gadget broke for מקף on 10 July, not why it has already been broken for Tuválkin mid-June. —Tacsipacsi (talk) 00:51, 19 July 2023 (UTC)

It’s still not working for me, but then again GalleryDetails not working in any category right now. I also noticed that another gadget that offers a dropdown with all the filetypes shown in a category page, allowing to filer for one of them — it’s also not working: The dropdown just vanished. -- Tuválkin ✉ ✇ 01:03, 19 July 2023 (UTC)

Thanks for the ping. I made this change, let me know if that helps. Arlolra (talk) 15:56, 20 July 2023 (UTC)

@Arlolra: Thank you very much! It’s apparently working everywhere except in Category:Low quality runic letters, as before. -- Tuválkin ✉ ✇ 01:13, 21 July 2023 (UTC)

That seems to be because File:Rune-Stan.png has a missing file revision. I think the following change should fix it:

@@ -650,7 +650,7 @@
                 for (var u = 0; u < this.image_list[i].users.length; u++) {
                   var match = null; 
                   var user  = this.image_list[i].users[u].user;
-                  if (user.replace (/ /g, '_') == 'Flickr_upload_bot') {
+                  if (user == 'Flickr upload bot') {
                     // Check for the bot's upload template
                     match =
                       /\{\{User:Flickr upload bot\/upload(\|[^\|\}]*)?\|reviewer=([^\}]*)\}\}/.exec (text);

(It doesn’t work because on missing file revisions, this.image_list[i].users[u].user is undefined, so calling .replace() on it fails. I don’t think the API ever returns user names with underscores, so simply skipping the normalization won’t cause any User:Flickr upload bot uploads to be missed. Except of course if the Flickr upload bot upload is a missing file revision, but we can’t really do anything about those cases.) —Tacsipacsi (talk) 14:50, 21 July 2023 (UTC)

Thank you, but there’s a big hiccup: Unlike previously, GalleryDetails now shows on the 1st column only the thumbnail, not also the file-name and -size as before, leaving no “handles” to click on it to select each file for Cat-a-lot — which is the use, I reckon, most people had for this function, something more just than same screen viewing of all filepages. -- Tuválkin ✉ ✇ 23:17, 21 July 2023 (UTC)

@Tacsipacsi: No news? -- Tuválkin ✉ ✇ 09:01, 4 August 2023 (UTC)

@Tuvalkin: I’ve made the edit suggested by Tacsipacsi above; disabling the edit request since I don’t see anything else that’s actionable for interface administrators, even if there still are other problems. --Lucas Werkmeister (talk) 19:44, 30 September 2023 (UTC)

Just put it back as it was before, when it worked and we could use it. -- Tuválkin ✉ ✇ 21:33, 30 September 2023 (UTC)

@Tuvalkin: I’m sorry, that’s not an actionable edit request. When you first reported issues in June, the gadget code hadn’t been edited since 2016; there’s nothing we can “put back” on Commons. Also, the gadget actually seems to be working quite well for me on Category:Low quality runic letters – the “gallery details” tool link appears, and when I click it, the category gets reformatted with lots of details for each file. If you’re still experiencing issues, please provide more details. --Lucas Werkmeister (talk) 11:18, 1 October 2023 (UTC)

Please read my post of 23:17, 21 July 2023. We don’t care whether you roll it back to the 2016 status or you just redevelop the crippled function from the ground up, but, as it is now, Gallery details is useless for any useful work. -- Tuválkin ✉ ✇ 11:29, 1 October 2023 (UTC)

No working for any cats

It is requested that an edit or modification be made to this protected page.
Administrators: Please apply <nowiki> or {{Tl}} to the tag after the request is fulfilled.

---

Fulfill this request after checking that the code is safe, beautify and escape unsafe characters

Tuvalkin

As explained above, GalleryDetails now shows on the 1st column only the thumbnail, not also the file-name and -size as before, leaving no “handles” to click on it to select each file for Cat-a-lot — which is the use, I reckon, most people had for this function, something more just than same screen viewing of all filepages. Is it very hard to just add some text or maybe just border-bottom:12px or just anything that can be used to click on so it gets selected for Cat-a-lot? -- Tuválkin ✉ ✇ 11:32, 1 October 2023 (UTC)

In Category:Lisbon alone, there an additional logjam of a few thousand images due to this issue. It’s really sad to see this "break everything" mentality fully installed in Wikimedia projects. -- Tuválkin ✉ ✇ 22:55, 11 December 2023 (UTC)